Interrupting an rr test blows away the test directory
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.7k
- Forks
- 662
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 2
Description
After #1147, we default to blowing away the tmp dir on exit. Previously we only did this when the test explicitly passed. The problem is when I Ctrl-c interrupt a test, I often want to do something with the contents of the test dir.
We can make the leave_data var be tri-state, initially "?" or something, and then updating it would be leave_data = ('y' == leave_data ? 'y' : test_passed() ? 'n' : 'y'). @rocallahan do you see any problems with that?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the leave_data state and the test_passed() update described in the issue, then trace how the test directory is removed on exit. Reproduce a Ctrl-C interruption and verify that the test directory contents remain available while the existing cleanup behavior for completed tests is preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100