rossoctl / rossoctl/workload-harness

Add --namespace flag to all scripts as alternative to NAMESPACE env var

Open
#41 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

stale
Dominant language
Shell
Stars
5
Forks
6
Avg merge
11h 37m
Merged PRs (30d)
1

Description

Summary

Namespace is currently controlled via the NAMESPACE env var (defaulting to team1). Scripts should also accept a --namespace CLI flag so callers can specify it inline without prefixing every invocation with an env var assignment.

Affected scripts

  • deploy-agent.sh
  • deploy-benchmark.sh
  • deploy-and-evaluate.sh
  • evaluate-benchmark.sh

Proposed behaviour

  • Add --namespace NAMESPACE to each script's argument parser.
  • CLI flag takes precedence over the env var; env var takes precedence over the hardcoded default (team1).
  • Pass --namespace through in wrapper scripts (deploy-and-evaluate.sh) the same way other flags are forwarded.

Motivation

Running parallel experiments in different namespaces (e.g. team2) currently requires either editing scripts or prepending NAMESPACE=team2 to every call. A --namespace flag makes this composable with other flags and easier to use in scripts and CI.

Related: #38 (OCP runner hardening), noted in PR #33 review by @kellyaa.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the argument parsers in deploy-agent.sh, deploy-benchmark.sh, deploy-and-evaluate.sh, and evaluate-benchmark.sh, then compare how existing flags are forwarded by deploy-and-evaluate.sh. Done means each script accepts --namespace NAMESPACE with CLI-over-environment-over-default precedence, and the wrapper passes the flag through consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
cli, devops
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
76/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.