rose-pine / rose-pine/zed

`number` and `constant` tokens use `$gold`, but per the Rosé Pine palette spec they should be `$rose`

Open Beginner friendly
#30 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
66
Forks
13
PR merge metrics
No merged PRs in 30d

Description

In src/template.json (source for all three Zed theme variants), the syntax mapping uses the wrong palette role for numeric and constant literals:

"constant": { "color": "$gold" }
"number": { "color": "$gold" }

According to the Rosé Pine palette spec, rose is the role for booleans/constants, while gold is reserved for string literals. number/constant are currently mapped to gold, which is incorrect according to the spec. This also diverges from other official ports (Sublime Text and VSCode map constant.numeric/constant.language to rose).

Proposed change in src/template.json:

"constant": { "color": "$rose" },
"number": { "color": "$rose" }

Side note: operator is currently $subtle — consider $pine (or maybe $iris) to make it more distinguishable from normal punctuation, but that's just a suggestion. (VS Code renders operators in pine, for reference)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/template.json, the source for all three Zed theme variants, and compare its constant and number mappings with the Rosé Pine palette spec. Change those mappings to the specified palette role, leaving the optional operator suggestion out of scope. Done means the template reflects the spec for both token types across generated variants.

Written by the indexing model from the issue text.

Assessment

Domain
design
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
85/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.