Re-enable tests when intra process manager takes an allocator again
@wjwwood is already working on this.
Since Oct 25, 2019.
- Dominant language
- C++
- Stars
- 80
- Forks
- 34
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 1
Description
The test was disabled in https://github.com/ros2/realtime_support/pull/84 and it needed to be disabled because the refactored intra-process manager in rclcpp unfortunately did not have the ability to control allocations in its merged state, see:
https://github.com/ros2/rclcpp/pull/778
However, the plan is update that implementation soon to again take an allocator and allow for complete control over all allocations. At that time, the disabled test should be re-enabled.
Also, at the same time it would be a good idea to refactor this test to use https://github.com/osrf/osrf_testing_tools_cpp#memory_tools instead of a custom new and delete as that approach has limitations. Also to consider how it may not work correctly for all rmw implementations, see:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.