ros2 / ros2/rclcpp

lifecycle_publisher: method naming

Open
#976 2 comments 0 reactions 1 assignee View on GitHub

@Karsten1987 is already working on this.

Since Feb 13, 2020.

question
Dominant language
C++
Stars
805
Forks
564
Avg merge
1d 17h
Merged PRs (30d)
27

Description

Probably not the most important issue but I felt like inquiring about it :)

Is there a rationale behind naming the methods on_activate() and on_deactivate() with the "on" prefix in LifecyclePublisherInterface?

To me, it feels wrong to call these methods directly. They feel like state transition methods that should be called internally when a state transition is requested. Just like in LifecycleNodeInterface I would expect to have methods activate() and deactivate() which would then trigger the state transition.

This is probably loosely related to #654. A universal lifecycle interface for nodes and helper classes with automatic triggering of state transitions would be great!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.