Odd parameter overrides' ordering when using wildcards
@ivanpauno is already working on this.
Since Jun 26, 2020.
- Dominant language
- C++
- Stars
- 805
- Forks
- 564
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 27
Description
Bug report
Required Info:
- Operating System:
- Ubuntu 18.04
- Installation type:
- Binaries
- Version or commit hash:
- Eloquent (mostly 0.8.1)
- Client library (if applicable):
- rclcpp
Steps to reproduce issue
-
Write a parameter YAML file,
explicit_params.yaml, settinguse_sim_timeexplicitly referring to a node:talker: ros__parameters: use_sim_time: false -
Write a parameter YAML file,
wildcard_params.yaml, settinguse_sim_timeimplicitly using wildcards:/**: ros__parameters: use_sim_time: true -
Run a
talkernode:-
Passing the parameter YAML file using wildcards first:
ros2 run demo_nodes_cpp talker --ros-args --params-file path/to/wildcard_params.yaml --params-file path/to/explicit_params.yaml -
Passing the parameter YAML file being explicit first:
ros2 run demo_nodes_cpp talker --ros-args --params-file path/to/explicit_params.yaml --params-file path/to/wildcard_params.yaml
-
Expected behavior
I'm not sure if we've ever fully specified behavior when using wildcards.
-
If wildcards have lower precedence than fully qualified names, command line order should not matter i.e.
use_sim_timealwaysfalse. -
If command line order is respected,
use_sim_timeshould befalsein the first case,truein the second case.
Actual behavior
First given override wins.
Additional information
This is inconsistent with how it works for rclpy nodes, where command line order is respected. Looking at both rclpy and rclcpp implementations, it looks behavior emerged by pure chance. We should probably be matching wildcards where we can enforce a consistent precedence, down in rcl.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.