ros2 / ros2/rclcpp

Can't call spin_until_future_complete inside a callback executed by an executor

Open
#773 7 comments 6 reactions 1 assignee View on GitHub

@wjwwood is already working on this.

Since Aug 8, 2019.

question
Dominant language
C++
Stars
805
Forks
564
Avg merge
1d 17h
Merged PRs (30d)
27

Description

Feature request

Feature description

spin_until_future_complete does not work recursively:

https://github.com/ros2/rclcpp/blob/0ccac1e3bd0f4314e11c86202c0c3ade57aed8ed/rclcpp/include/rclcpp/executors.hpp#L76

Could someone provide some background why this is not allowed?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.