ros2 / ros2/rclcpp

Add API for querying if intraprocess comm is enabled in pub/subs

Open
#689 1 comment 0 reactions 1 assignee View on GitHub

@fujitatomoya is already working on this.

Since Sep 1, 2023.

enhancement
Dominant language
C++
Stars
805
Forks
564
Avg merge
1d 17h
Merged PRs (30d)
27

Description

Feature request

Feature description

Add a method to Publisher and Subscription classes, which allows querying if intraprocess communication is enabled or not.

bool
is_intra_process_comm_enabled() const;
Reasoning

In #674 an extra argument has been added to create_publisher and create_subscription methods in Node class, which allows choosing if intraprocess communication is enabled or not with more granularity. The argument default value is NodeDefault which enables it or not depending on the node settings. That was the previous behavior.
Now, It's no way of checking if a publisher or subscriber has the intraprocess comm activated.
Also, it doesn't exist any test which sets the intraprocess comm with pub/sub granularity. This will allow to easily add a test.

Implementation considerations

Both publisher and subscriber has a bool storing the intraprocess subscription state, so we have to just return it.
I think it's also a good idea to add a test with intraprocess comm being set with pub/sub granularity.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.