ros2 / ros2/rclcpp

When can a Duration/Time be negative?

Open
#525 10 comments 0 reactions 1 assignee View on GitHub

@dhood is already working on this.

Since Jul 26, 2018.

question
Dominant language
C++
Stars
805
Forks
564
Avg merge
1d 17h
Merged PRs (30d)
27

Description

Spinning off from https://github.com/ros2/geometry2/pull/67#discussion_r205326838 so I don't hijack that thread (and so the convo doesn't get lost).

I thought that Durations could not store negative values but from @tfoote's comment it sounds like that understanding is incorrect. The source of my misunderstanding is this line:

https://github.com/ros2/rclcpp/blob/af6e86c522d674a58f935cabceea2108c7f64589/rclcpp/src/rclcpp/duration.cpp#L92

Should that check be removed? Or is it appropriate in that situation?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.