TimersManager doesn't follow ROS time
Open
@alsora is already working on this.
Since Jul 12, 2024.
- Dominant language
- C++
- Stars
- 805
- Forks
- 564
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 27
Description
Feature request
Feature description
Currently, the TimersManager class waits for timers to be ready using the following code
timers_cv_.wait_for(lock, time_to_sleep.value(), [this]() {return timers_updated_;});
This will always sleep using the system clock, even if the "time to sleep" was computed from a timer using the ROS clock
We should take into account the clock type when deciding how to sleep, and use an API that is aware of ROS clock
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.