StaticSingleThreadedExecutor uses spin_once in spin
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 805
- Forks
- 564
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 27
Description
This change seems to have been made in https://github.com/ros2/rclcpp/pull/2142
while (rclcpp::ok(this->context_) && spinning.load()) {
this->spin_once_impl(std::chrono::nanoseconds(-1));
}
I guess it should be
while (rclcpp::ok(this->context_) && spinning.load()) {
this->spin_all(std::chrono::nanoseconds(0));
}
@mjcarroll @wjwwood
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with rclcpp/src/rclcpp/executors/static_single_threaded_executor.cpp at the loop linked in the issue, then review the referenced pull request 2142 for context. Compare the current spin call with the proposed spin_all call and confirm that the executor's spin behavior matches the intended change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 38/100