ros2 / ros2/rclcpp

Should `spin_once()` be called from multiple threads?

Open
#2,098 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
805
Forks
564
Avg merge
1d 17h
Merged PRs (30d)
27

Description

Similar to this PR for rclpy: https://github.com/ros2/rclpy/pull/1079

Should we document that spin_once() should not be called from multiple threads?

Does that also apply to spin_node_once()?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the referenced rclpy pull request and the existing documentation for rclcpp's spin_once() and spin_node_once() APIs. Determine whether concurrent calls are supported, then document the threading guidance for both functions and verify the resulting API documentation.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
documentation
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.