[rclcpp] refactor Executor::add_callback_group to not need a node pointer
Open
@wjwwood is already working on this.
Since Sep 2, 2020.
enhancement
- Dominant language
- C++
- Stars
- 805
- Forks
- 564
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 27
Description
In https://github.com/ros2/rclcpp/pull/1218 the add_callback_group() method was added, but it required us to pass the node associated with the callback group as well, because it was still needed internally in the executor and because the callback group doesn't have a back reference to the node that created it.
We need to change this so it is no longer required because the library can have all this information and asking the user to provide it is redundant and can only lead to misuse, i.e. it has no practical value or serves no extra use case.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.