Inconsistent namespaces for memory strategies
Open
@brawner is already working on this.
Since Jun 18, 2020.
- Dominant language
- C++
- Stars
- 805
- Forks
- 564
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 27
Description
It looks like the namespacing of memory strategies is not consistent and could be due for cleanup. Please let me know if this is intentional and should be left alone.
// include/rclcpp/strategies
rclcpp::strategies::message_pool_memory_strategy::MessagePoolMemoryStrategy;
rclcpp::memory_strategies::allocator_memory_strategy::AllocatorMemoryStrategy;
// include/rclcpp
rclcpp::memory_strategy::MemoryStrategy;
rclcpp::memory_strategies::create_default_strategy();
I'm ticketing this while it's fresh in my mind, and I plan to come back around and propose a PR.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.