Allow optional scoping for including a launchfile
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 155
- Forks
- 182
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 6
Description
Feature request
IncludeLaunchDescription is not scoped if I understand correctly. (Based on #313 #689 and the design docs)
Feature description
An extra argument for IncludeLaunchDescription action, which could enable scoping.
This would prevent the leakage of arguments.
Implementation considerations
This is already possible by including into a group with forwarding set to false.
Default could be false to not break the current behavior.
EDIT: I made a proof of concept package https://github.com/SuperJappie08/launch_scoped_include/, which implements this on a new action called IncludeScopedLaunchDescription
EDIT2: I can make a pull request for this if the feature is desired
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the IncludeLaunchDescription action and read the linked ROS 2 launch design documentation, along with issues #313 and #689. Review the launch_scoped_include proof-of-concept to understand the proposed optional scoping behavior. Done means an optional scope prevents argument leakage while preserving current behavior by default.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100