LaunchDescriptionSource does not expand substitution
Open
Nobody has claimed this yet.
bug
help wanted
- Dominant language
- Python
- Stars
- 155
- Forks
- 182
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 6
Description
When using some code:
act = IncludeLaunchDescription(
PythonLaunchDescriptionSource(PathJoinSubstitution([FindPackageShare(package), "launch", launch_file]))
Trying to determine the file being included doesn't seem to work properly due to substitutions not being properly expanded:
test/launch_ext/test_include_package_launch_file.py:11: in test_include_package_launch_file
assert act.launch_description_source.location == 'launch/launch_file.py'
E AssertionError: assert '<launch.subs...7fe35e8126b0>' == 'launch/launch_file.py'
E - launch/launch_file.py
E + <launch.substitutions.path_join_substitution.PathJoinSubstitution object at 0x7fe35e8126b0>
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at launch/launch/launch_description_source.py around line 106 and inspect how IncludeLaunchDescription handles the PathJoinSubstitution shown in the issue. Run test/launch_ext/test_include_package_launch_file.py, then verify that the launch description source location is the resolved path rather than the substitution object's representation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100