ros2 / ros2/launch

Add more convenient Include action

Open
#634 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help wanted
Dominant language
Python
Stars
155
Forks
182
Avg merge
2d 14h
Merged PRs (30d)
6

Description

Feature request

This is a request to make it simpler to include a launch file from a ROS package. Currently it looks like this:

IncludeLaunchDescription(
    AnyLaunchDescriptionSource(
          [FindPackage('my_package'), '/share/my_package/launch/my_launch.py'])),

But it could look like this:

from launch_ros.actions import IncludeLaunchFile
# ...
IncludeLaunchFile(package='my_package, file='my_launch.py')
Implementation considerations

This would remove the need to know the full path to the launch file. FindPackage might return a path that's shared with many other packages in a merged workspace (like /opt/ros/dashing), so it should limit the search to share/my_package.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the existing IncludeLaunchDescription, AnyLaunchDescriptionSource, and FindPackage usage shown in the issue, along with the launch_ros.actions entry point. Define the new package-and-file inclusion behavior and verify that lookup is limited to the package's share directory; done means the shorter example works without requiring the full launch-file path.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.