ros2 / ros2/launch

Passing array args broken in XML backend

Open
#633 3 comments 0 reactions 1 assignee View on GitHub

@hidmic is already working on this.

Since Aug 18, 2022.

Dominant language
Python
Stars
155
Forks
182
Avg merge
2d 14h
Merged PRs (30d)
6

Description

Bug report

Required Info:

  • Operating System:
    • MacOS 12.3
  • Installation type:
    • source
  • Version or commit hash:
    • humble
Steps to reproduce issue
<launch>
    <arg name="int_array" default="1,2,3,4,5,6,7" />

	<node pkg="test_node" name="test_node" exec="test_node">
		<param name="int_array"  value-sep="," value="$(var int_array)" />
	</node>
</launch>
Expected behavior

Should correctly pass the arg int_array as integer array to the node.

Actual behavior

Passes ['1,2,3,4,5,6,7'] instead:

[test_node-1] libc++abi: terminating with uncaught exception of type rclcpp::exceptions::InvalidParameterTypeException: parameter 'ids_to_ignore' has invalid type: Wrong parameter type, parameter {int_array} is of type {integer_array}, setting it to {string_array} is not allowed.```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.