ros2 / ros2/launch

TTY emulation support for windows

Open
#268 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help wanted
Dominant language
Python
Stars
155
Forks
182
Avg merge
2d 14h
Merged PRs (30d)
6

Description

Feature request

Feature description

TTY emulation in windows (currently only supported elsewhere).

Implementation considerations

Breadcrumbs in code:

  • Guarding against windows emulation in launch/actions/execute_process.py
  • Test in test/launch/actions/test_emulate_tty.py

Turning the guard off on windows:

  • Does not result in a tty
  • Other spurious unicode errors

Other:

  • The pty module is not supported on windows (looks like folk often make use of winpty).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Windows guard in launch/actions/execute_process.py and the existing coverage in test/launch/actions/test_emulate_tty.py. Investigate the stated limitation of Python's pty module on Windows and the winpty option; done means Windows TTY emulation works without the reported lack of a tty or spurious Unicode errors, with the test coverage updated.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.