[launch] prevent Actions from being reused
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 155
- Forks
- 182
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 6
Description
Currently if you provide an instance of an Action to be visited more than once it will be and that breaks the assumption of one time use of some Actions like ExecuteProcess.
Instead Actions should declare if they're reusable or not (default to not probably) and then get an appropriate error when they are accidentally reused.
Follow up of https://github.com/ros2/launch/issues/90#issuecomment-400852504
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how an Action is visited more than once and how ExecuteProcess is handled. Define how Actions declare reusability and how accidental reuse is reported; done means non-reusable Actions are rejected on a second visit while reusable Actions continue to work, with tests covering both cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100