ros2 / ros2/launch

[launch] improve test coverage for non-core classes

Open
#102 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

backlog enhancement
Dominant language
Python
Stars
155
Forks
182
Avg merge
2d 14h
Merged PRs (30d)
6

Description

Currently there are minimal tests for some of the core classes like LaunchDescription, LaunchService, and Action, but there's not really any tests for things like:

  • launch.LaunchInstrospector
  • launch.Substitution
  • anything in the namespaces:
    • launch.actions
    • launch.event_handlers
    • launch.events
    • launch.substitutions
    • launch.utilities

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the existing tests for LaunchDescription, LaunchService, and Action, then inventory coverage for LaunchInstrospector, Substitution, and the launch.actions, launch.event_handlers, launch.events, launch.substitutions, and launch.utilities namespaces. Define the missing cases for each class or namespace and consider the work complete when meaningful tests cover the identified non-core components.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.