ros2 / ros2/geometry2

reuse logic from Time::durationToSec method

Open
#68 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
153
Forks
256
Avg merge
3d 23h
Merged PRs (30d)
14

Description

As suggested in https://github.com/ros2/rclcpp/pull/536#discussion_r211035479 the logic could be moved to rcutils and be used in rclcpp::Time and rclcpp::Duration.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the logic in tf2/include/tf2/time.h at lines 74–84 and the discussion in rclcpp pull request 536. Trace how rclcpp::Time and rclcpp::Duration use this conversion, then determine the rcutils location and tests needed so both types reuse the shared logic.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
robotics
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.