ros2 / ros2/common_interfaces

Duplicate action message definitions

Open
#64 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
393
Forks
157
PR merge metrics
No merged PRs in 30d

Description

Feature request

Feature description

There actionlb_msgs defined in this repository appear to be a duplicate of the action_msgs defined in rcl_interfaces: https://github.com/ros2/rcl_interfaces/tree/master/action_msgs

It is confusing having both of these as it isn't clear which one should be used and may cause fragmentation going forward. If possible one of these should be deleted or at the very least renamed.

Implementation considerations

I assume that one of these is here for some historical reason. If there are dependency reasons that one of these cannot be deleted yet then it would be good to at least mark them as deprecated and document what should be used. If someone knows which of these should actually be kept going forward it would be nice to have that information added to this issue.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the actionlb_msgs definitions in this repository with action_msgs in rcl_interfaces, starting with the linked package contents and the repository's dependency references. Done means the project has one clearly identified canonical definition, with the duplicate removed or its deprecation and replacement documented if dependencies prevent removal.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
api
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.