ros2 / ros2/common_interfaces

Marker.msg DELETE field conflicts with windows SDK 8.1

Open
#44 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
393
Forks
157
PR merge metrics
No merged PRs in 30d

Description

Bug report

It looks like I've found one more conflict with Windows SDK 8.1.
Windows SDK defines DELETE macro in winnt.h.
src\ros2\common_interfaces\visualization_msgs\msg\Marker.msg uses
uint8 DELETE=2

Required Info:

  • Operating System:
    Win 8.1
  • Installation type:
    source
  • Version or commit hash:
    beta3-release
  • DDS implementation:
    RTI Connext
  • Client library (if applicable):
    rmw_connext_cpp
Steps to reproduce issue

ament build

Expected behavior

compile sucesss

Actual behavior

compile fails

Additional information

@serge.nikulin

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src\ros2\common_interfaces\visualization_msgs\msg\Marker.msg and inspect the DELETE field alongside the Windows SDK definition in winnt.h. Reproduce the failure with ament build on Windows 8.1, then verify that the common interface compiles successfully without the macro conflict.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system, operating-systems
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.