ros2 / ros2/common_interfaces

`sensor_msgs_py.point_cloud2` functions treat numpy arrays as having shape (width, height)

Open
#236 3 comments 0 reactions 1 assignee View on GitHub

@mjcarroll is already working on this.

Since Dec 21, 2023.

Dominant language
C++
Stars
393
Forks
157
PR merge metrics
No merged PRs in 30d

Description

I'm not sure if this is really a problem or just a different convention but it was something that surprised me that I had to work around. I see that for organized clouds both the read_points and create_cloud functions have logic that treat the input/output ndarray of having a shape where the cloud width is the first index (rows), and the cloud height is the second (columns). I suppose it works if you always follow that convention but I think most other code will treat it with the opposite convention and some axes swapping is necessary.

I think pretty much only the bits I linked would have to be changed to make the switch. @Flova what are your thoughts as the original PR author?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.