ros2_batch_job --workspace-path option does not work
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 55
- Forks
- 39
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 7
Description
Looking at the code we see that the argparse option declared here:
is not actually used anywhere in the code. So setting this option has no affect on the job.
I'm not sure exactly how to fix the argument because I don't understand the purpose of the --white-space-in option, which is coupled to determining the actual workspace named used:
If I'm not mistaken, this section of code is relevant as well:
Here are other references to the option I could find:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in ros2_batch_job/main.py at the argparse declaration around lines 238-240, then trace workspace-name handling around lines 267-270 and 427. Compare those paths with the --workspace-path references in job_templates/ci_job.xml.em at lines 123, 265, and 368. Done means setting --workspace-path changes the workspace used by the batch job without breaking the related whitespace option.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- ci-cd, cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100