Python warnings are not reported by CI
@nuclearsandwich is already working on this.
Since May 4, 2020.
- Dominant language
- Python
- Stars
- 55
- Forks
- 39
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 7
Description
Neither colcon test nor Jenkins report warnings coming from Python code. For example, deprecated API was recently introduced in https://github.com/ros2/ros2cli/pull/463 but CI passes without reported the warnings. I would expect an unstable build so that we notice things like deprecated Python APIs and can address them.
Here is an example build testing ros2node:
It is unstable for a different reason. The point is there are 61 warnings visible in the console, but they are not reported by Jenkins: https://ci.ros2.org/job/ci_linux/9731/consoleFull#console-section-223
Specifically for tests, I tried passing a pytest argument to treat warnings as errors (https://github.com/ros2/ci/pull/416), but this results in a failed build, instead of unstable, which I think is not desired.
Related colcon PR to report pytest warnings: https://github.com/colcon/colcon-core/pull/236
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.