ros2 / ros2/ci

Support rebasing forked repo against default branch in upstream repo

Open
#17 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
55
Forks
39
Avg merge
1d 13h
Merged PRs (30d)
7

Description

If we specify a particular branch on the ros2 repos to test for the CI jobs, we will rebase that branch against master.

There are cases when it would be useful to do the same when testing a given ros2.repos file, such as checking that PRs from external contributors will work correctly even after being rebased.

(There are probably also cases when we would not want to rebase)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in ros2_batch_job/main.py around the branch-rebasing logic linked near line 414, then trace how a selected ros2.repos file is tested. Determine how the default branch in the upstream repository should be identified and when rebasing should be optional. Done means the requested forked-repository case works without changing cases where rebasing is not wanted.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
ci-cd
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.