ros-controls / ros-controls/topic_based_hardware_interfaces
Possibility to deactivate `trigger_joint_command_threshold_`
Open
good first issue
- Dominant language
- C++
- Stars
- 13
- Forks
- 11
- Avg merge
- 5h 11m
- Merged PRs (30d)
- 3
Description
Little outside of the scope here, but what do you think about explicitly disabling this (
trigger_joint_command_threshold_ = -1;) unless the user sets the value. Personally I would assume it would always publish unless configured.
Originally posted by @MarqRazz in https://github.com/ros-controls/topic_based_hardware_interfaces/pull/44#discussion_r2445624811
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.