ros-controls / ros-controls/ros2_controllers
Use methods in all controller in the same order (Let's make controller development a joy)
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 834
- Forks
- 530
- Avg merge
- 18h 3m
- Merged PRs (30d)
- 19
Description
Hi,
Working on an extension of JTC (#140), it's very disturbing (or at least disconcerting) not having unified members/methods order between the different controllers and the controller_interface. The issue I have is jumping between different states of the controller and having to check all the time at which lifecycle state controller is, i.e., which members are filled and which not...
I propose to restructure controller_interface methods to the execution order and keep that throughout this repository.
P.S. I know this is a very unproductive request. Still, IMHO it's important to increase understanding and finally acceptance of the library...
Any thoughts?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing controller_interface and the controller implementations to inventory their lifecycle members and methods. Compare the ordering across controllers and identify the execution order the issue proposes to standardize. The work is done when the relevant controllers consistently follow one documented method order and existing tests still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- robotics
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100