ros-controls / ros-controls/control_toolbox
Evaluate if the ROS parameters handling can be improved
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 176
- Forks
- 124
- Avg merge
- 3h 44m
- Merged PRs (30d)
- 9
Description
There are wrappers for getting ROS parameters with the comment
// TODO(anyone): to-be-removed once this functionality becomes supported by the param API directly
Evaluate, if there is already a cleaner way in the rclcpp API. If not, we should consider using generate_parameter_library here, which is already a dependency of this package.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the parameter wrappers in control_toolbox/src/pid_ros.cpp around lines 132-183 and checking the referenced rclcpp parameter API. Compare the existing approach with the available API and the package's generate_parameter_library dependency. Done means documenting or implementing a decided cleaner approach, but the issue does not define which outcome is required.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- robotics
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100