ropensci / ropensci/refsplitr

Add tests with sample data including no matches

Open
#59 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
59
Forks
6
PR merge metrics
No merged PRs in 30d

Description

When using the author_match function, errors occurred, when I would provide small subsets of my data, that didn't include any entries, that would match up with other entries. By including such an example in the tests it should be possible to eliminate those errors.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the author_match function and its existing tests. Add a sample-data case where the inputs contain no entries that match, then run the relevant test suite; done means the case runs without errors and guards against the reported failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.