ropensci / ropensci/osmplotr

use vcr to mock tests

Open
#39 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
142
Forks
22
No merged PRs in 30d

Description

The problems highlighted in osmdata issues #126 and #128 are pervasive, and affect CRAN systems too, causing tests to fail. vcr is finally on CRAN, so can be used to mock tests far more neatly and comprehensively than current approach.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review osmdata issues #126 and #128 first, then inspect osmplotr's current test setup and the vcr package documentation. The work is complete when external OpenStreetMap-related requests are mocked through vcr and the test suite no longer fails on CRAN systems.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.