osm_line2poly limitations
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 142
- Forks
- 22
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
I don't have time to track this down at present, but the following bounding box leads to incorrect behaviour in osm_line2poly for this bit of coastline
bbox.F <- rbind(c(min= 144.75, max = 145.6),
c(min= -38.41, max = -37.75))
rownames(bbox.F) <- c("x", "y")
I think the problem is cause by multiple cutting of peninsulas.
May be that the current approach is too simple, and that we need to do something quite complex, probably requiring sf, unfortunately.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the incorrect coastline behavior in osm_line2poly using the bbox.F coordinates shown in the issue, then inspect that entry point and its current cutting approach. Determine how repeated peninsula cuts should be handled, including whether sf is needed, and verify that the bounding box produces the correct coastline geometry.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data-visualization
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100