node-resolve plugin discards this re-exported file

Open
#1,946 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, node.js
Domain
build-system, tooling

Research direction

Start with the linked StackBlitz reproduction and inspect @rollup/plugin-node-resolve's handling of the re-exported util.inspect.js file. Compare the generated vendor and index chunks with the source snippets; done when the require is preserved and the ReferenceError no longer occurs.

Written by the indexing model from the issue text.

Description

Expected Behavior

The re-export of ./util.inspect.js by object-expect should not be discarded, causing a run time failure.

index.js contains these lines

var utilInspect = require('./util.inspect');
var inspectCustom = utilInspect.custom;
var inspectSymbol = isSymbol(inspectCustom) ? inspectCustom : null;

This require should be preserved, as './util.inspect' contains just this line:

module.exports = require('util').inspect;
Actual Behavior

The require statement is mangled at some point:

vendor chunk (Zt is equivalent to v in the index chunk):

    var M = Zt // <--- error here
      , B = M.custom
      , re = J(B) ? B : null

index chunk

const p = {}
  , h = Object.freeze(Object.defineProperty({
    __proto__: null,
    default: p
}, Symbol.toStringTag, {
    value: "Module"
}))
  , v = f(h)

so that this error is produced (see repro link above):

Uncaught ReferenceError: Cannot access 'Zt' before initialization
    at _e (vendor-o4ka1zf0.js:9:5572)
    at In (vendor-o4ka1zf0.js:12:15964)
    at Fn (vendor-o4ka1zf0.js:12:19479)
    at Tn (vendor-o4ka1zf0.js:12:30519)
    at vendor-o4ka1zf0.js:12:30590
Additional Information

On my actual build (not the stack blitz) at what files are 'available' via source map, the whole 'util.inspect.js' file is missing

Dominant language
JavaScript
Stars
3.8k
Forks
635
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rollup/plugins

All issues in rollup/plugins

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.