rollbar / rollbar/rollbar-react
It is recommended to put prop-types in dependencies
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 46
- Forks
- 9
- Avg merge
- 2d 56m
- Merged PRs (30d)
- 4
Description
ref: https://github.com/facebook/prop-types#how-to-depend-on-this-package
rollbar-react users basically don't care about prop-types, so I think that it should be put in dependencies instead of peerDependencies.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by checking the package's dependency declarations and how prop-types is currently listed. Move it from peerDependencies to dependencies, then verify the package installation and existing React usage still work as expected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100