rollbar / rollbar/rollbar-react-native
Hardcoded minSdkVersion causes build failure when building for Detox
Nobody has claimed this yet.
- Dominant language
- Objective-C
- Stars
- 81
- Forks
- 34
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
Thank you for your work on this project.
I'd like to address a concern regarding the usage of Rollbar-react-native. It appears that the library does not adhere to the best practice of passing through minSdkVersion from the project's build.gradle file. While there might be valid reasons for this decision (unknown to me), it is causing difficulties when using Detox. The build process fails when the minSdkVersion specified in the Rollbar-react-native library is lower than the one indicated in the project's build.gradle file.
To address this issue, I've resorted to using patch-package as a temporary fix. However, this solution is clearly far from ideal.
See this (old but still accurate) issue on GitHub.
Thank you once again,
Daan
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the minSdkVersion declarations in the Rollbar-react-native library and the consuming project's build.gradle files, then reproduce the failure with the Detox build setup described in the issue. Done means the library no longer conflicts with the project's configured minSdkVersion and the Detox build succeeds without patch-package.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, react-native
- Domain
- build-system, mobile-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100