rollbar / rollbar/rollbar-java

Feature request: Add support for server metadata in RollbarAppender XML configuration

Open
#309 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

java
Dominant language
Java
Stars
78
Forks
74
PR merge metrics
No merged PRs in 30d

Description

Currently adding server metadata is only possible using java configuration example:

new ConfigBuilder.withAccessToken(accessToken)
                .environment(hostConfiguration.getEnvironment())
                .handleUncaughtErrors(true)
                .truncateLargePayloads(true)
                .language("java")
                .framework("spring")
                .server(() -> new Server.Builder()
                        .host(hostConfiguration.getHostId().getValue())
                        .metadata(Map.of(
                                "world", hostConfiguration.getWorld(),
                                "accountId", hostConfiguration.getAccountId()))
                        .build())
                .codeVersion(gitProperties.getShortCommitId())
                .build();

It would be nice if it was possible to add the server metadata from XML configuration in RollbarAppender for logback.

<appender name="rollbar-sync" class="com.rollbar.logback.RollbarAppender">
    <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
        <level>${rollbar.level}</level>
    </filter>
    <accessToken>${rollbar.api-key}</accessToken>
    <codeVersion>@git.commit.id@</codeVersion>
    <enabled>${rollbar.enabled}</enabled>
    <environment>${environment}</environment>
    <framework>spring-boot</framework>
    <language>java</language>
    <server>
        <host>${host-id}</host>
        <metadata>
            <account>${accountId}</account>
            <wrold>${world}</wrold>
        </metadata>
    </server>
</appender>

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the RollbarAppender entry point and compare its XML-configurable properties with the Java ConfigBuilder server metadata example. Verify how the server host and metadata should be represented in XML, then confirm that a configured RollbarAppender passes both values through when logging.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
observability
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.