rokwire / rokwire/groups-building-block

[TASK] Clean up storage transactions

Open
#230 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
1
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Description

Currently transactions are implemented within the storage adapter functions. They are also often used unnecessarily or improperly (eg. with a single operation, with some operations missing context)

Acceptance Criteria

As originally described here https://github.com/rokwire/core-building-block/issues/285. the storage adapter should expose individual storage operations and multi-stage transactions should be composed in the core package passing the storage.TransactionContext to each storage adapter function. Any unnecessary or improperly used transactions should be fixed or removed as appropriate.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the storage adapter functions and the core package flows that use transactions, then trace how storage.TransactionContext is passed today. Done means individual storage operations are exposed, multi-stage transactions are composed in the core package with the context passed to each adapter function, and unnecessary or improperly used transactions are removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.