rokucommunity / rokucommunity/vscode-brightscript-language

Device Discovery Improvements: Phase 2

Open
#685 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
132
Forks
60
Avg merge
13h 53m
Merged PRs (30d)
20

Description

Support adding a hand-curated list of devices that will always be in the list. (more details to come, just tracking the structure for now);

"brightscript.devices": [
	{
		"name": "guid",
		"host": "1.2.3.4",
		"password": "aaa",
		"favorite": true,
		"deviceId": "314sdfsd3"
	}
],

Other features:

  • when loading "brightscript.devices", should read from ALL the different places that vscode can define them, and establish a priority order (user wins probably?). (see debugConfigurationProvider for the workspaceConfiguration.inspect example)
  • better handling of when "last used device" goes away. (do we show it in the list but disabled?)
  • show devices all the time in the devics panel (with some type of offline status if missing).
  • figure out caching around devics only by their IP address (but you switched networks), or by deviceId (scan for devices, update ip address because deviceId wins, just for this session? Suggest updating settings?)
  • add a "enable/disable broadcasting" toggle in the device panel
  • if you manually type an IP address, we will "remember" that device by putting it in the devices list (and saving it in the list of devices we've seen, but treating it slightly more like all the other ones we've discovered by SSDP, not permanent).
  • "hide this device". gotta think about how this works...
  • Add some settings to manage various behaviors
    • "automaticDeviceScanning": "extension will scan for devices at smart times",
    • "lazyHealthChecking": "only health check devices when you interact with it (sideload to it, expand it)",
    • "whatConfigFilesToRead": [],
  • probably more...

host picking behaviors (#689)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the debugConfigurationProvider reference for the workspaceConfiguration.inspect example, then trace the device panel and device-discovery entry points. The issue is currently a tracking outline with more details to come, so completion criteria and the files to change are not yet defined.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
devtools, tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.