rokucommunity / rokucommunity/vscode-brightscript-language

Can't change remoteHost once set

Open
#588 21 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
132
Forks
60
Avg merge
13h 53m
Merged PRs (30d)
20

Description

It would seem that once the IP of the Roku device to which you want to send remote keypresses to is set, it is then impossible to update it.
This is due to the value being stored as a memento (remoteHost) in the workspace database (stored in state.vscdb), and once set the function
getRemoteHost will always use that value regardless of the settings parameter (e.g. "brightscript.remoteControl.host":"11.23.56.90")

Using SQLite browser it is possible to update the value, and this new value is then used by the extension.

e.g.
{"rokuAutomationAutorunOnDeploy":true,"rokuAutomationConfigs":"{\"configs\":[{\"name\":\"DEFAULT\",\"s0teps\":[]}]}","remoteHost":"11.23.56.90","rokuAppOverlays":[]}

Perhaps a solution would be to always use the value from the VSCode settings, and if the value is ${promptForHost} show the input and then overwrite the setting with whatever the user entered?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the getRemoteHost function and the handling of the brightscript.remoteControl.host setting and remoteHost memento. Reproduce the behavior with a stored remoteHost, then verify that changing the VS Code setting or using ${promptForHost} updates the host used by the extension.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
developer-experience, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.