rokucommunity / rokucommunity/vscode-brightscript-language

Improve deep link support

Open
#264 0 comments 0 reactions 1 assignee View on GitHub

@chrisdp is already working on this.

Since Jul 15, 2020.

enhancement
Dominant language
TypeScript
Stars
132
Forks
60
Avg merge
13h 53m
Merged PRs (30d)
20

Description

Hey everyone! We are currently talking about away to make deep link support more flexible and easier to configure. Including support for many deep combinations. I think we are mostly set on the structure but are looking for some feedback on the naming of the object where you define all your combinations. The current name options are testCases, options, or useCases.

The goal is just to make sure that for people coming to the extension for the first time they are less likely to get confused. Thanks!

	"deepLink":
		"enabled": false
		"activeTestCase": "main",
		"testCases": {
			"main": {
					"contentid": "12",
					"mediaType": "episode"
			}
		}
	},
	---------------------
	"deepLink":
		"enabled": false
		"activeOption": "main",
		"options": {
			"main": {
					"contentid": "12",
					"mediaType": "episode"
			}
		}
	},
	---------------------
	"deepLink":
		"enabled": false
		"activeUseCase": "main",
		"useCases": {
			"main": {
					"contentid": "12",
					"mediaType": "episode"
			}
		}
	},

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.