rokucommunity / rokucommunity/brighterscript

Catch missing function in scope for observers

Open
#777 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
208
Forks
68
Avg merge
8h 39m
Merged PRs (30d)
39

Description

If we have a call like

m.poster.observeFieldScoped("loadStatus", "onLoadStatusChange")

if onLoadStatusChange does not exist in the scope then we should let the user know. This would be very difficult if we tried to make it work with variables so that is not in scope for this work but would still be helpful to those using observers directly.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the observeFieldScoped call path and trace how the named observer function is resolved in scope. Add a diagnostic when the named function is absent, while leaving variable-based observers out of scope; done means the example reports the missing function clearly.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.