rokucommunity / rokucommunity/brighterscript
bug: class transpiling modifies AST
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 208
- Forks
- 68
- Avg merge
- 8h 39m
- Merged PRs (30d)
- 39
Description
Transpiling a class sometimes modifies the AST. Here's a unit test:
it.only('does not mess with AST when injecting `super()` call', async () => {
const file = program.setFile('source/classes.bs', `
class Parent
end class
class Child extends parent
sub new()
super()
end sub
end class
`);
expect(
(file.ast as any).statements[1].body[0].func.body.statements[0].expression.callee.name.text
).to.eql('super');
await program.transpile([], program.options.stagingFolderPath);
expect(
(file.ast as any).statements[1].body[0].func.body.statements[0].expression.callee.name.text
).to.eql('super');
});
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the unit test shown in the issue and trace the class transpilation path reached by program.transpile. Verify that injecting the super() call does not mutate the existing AST, and keep the test passing with the callee name still reported as super after transpilation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100