rokucommunity / rokucommunity/brighterscript

Quotes in template strings break "go to symbol" requests

Open
#570 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
208
Forks
68
Avg merge
8h 39m
Merged PRs (30d)
39

Description

The "Go to Symbol In Editor" logic results in wrong line numbers for every time a template string contains a quote.

https://user-images.githubusercontent.com/2544493/164732575-99d09e52-503b-40b4-b0c0-2a18e8b3e13a.mp4

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Go to Symbol In Editor logic and reproduce the issue using a template string containing a quote. Trace how line numbers are calculated, then verify that symbol requests report the correct lines for templates with and without quotes.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.