rokucommunity / rokucommunity/brighterscript
global instr function supports two different param styles
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 208
- Forks
- 68
- Avg merge
- 8h 39m
- Merged PRs (30d)
- 39
Description
the instr method has an undocumented function overload. Here are the known signatures:
Instr(start as Integer, text as String, substring as String) as Integer
Instr(text as String, substring as String) as Integer
We should support both patterns. Right now we don't even support method overloading for the roku methods...so we should do that too.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests; start by locating the global instr implementation and the existing Roku-method handling for overloads. Trace how the two listed signatures are represented, then identify the relevant tests. Done means both documented call forms are accepted with the stated parameter order.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100