rokucommunity / rokucommunity/brighterscript

Duplicate diagnostic for missing base class across files

Open
#483 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug performance
Dominant language
TypeScript
Stars
208
Forks
68
Avg merge
8h 39m
Merged PRs (30d)
39

Description

There seem to be duplicate diagnostics being generated internally anytime a base class is missing. These appear one diagnostic for every file in that scope. I think we need to refactor the ClassValidator class a bit. It seems like it's re-running full class list generation for every scope file.

image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the ClassValidator class and tracing how it generates diagnostics for each scope file. Reproduce the missing-base-class case described in the issue, then verify that the diagnostic is reported once rather than once per file while preserving other class validation behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.