rokucommunity / rokucommunity/brighterscript
trailing comma after bsconfig entry causes crash
Open
Nobody has claimed this yet.
bug
- Dominant language
- TypeScript
- Stars
- 208
- Forks
- 68
- Avg merge
- 8h 39m
- Merged PRs (30d)
- 39
Description
Certain trailing commas in bsconfig cause the bsconfig.json parser to crash. We're using a more flexible parser, so we should figure out how to better recover from that.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the bsconfig.json parser and reproducing the crash with a configuration containing a trailing comma. Trace how the flexible parser handles that input, then verify that it recovers without crashing and add or update coverage for the case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100