rokucommunity / rokucommunity/brighterscript

Errors when typing conditional compile blocks

Open
#367 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug LanguageServer
Dominant language
TypeScript
Stars
208
Forks
68
Avg merge
8h 39m
Merged PRs (30d)
39

Description

[Error - 3:16:44 PM] [object Object]
[Error - 3:16:44 PM] Request textDocument/codeAction failed.
  Message: Request textDocument/codeAction failed with message: TypeError: Cannot read property 'end' of undefined
    at Util.rangesIntersect (/Users/chris/.vscode/extensions/rokucommunity.brightscript-2.17.9/node_modules/brighterscript/dist/util.js:438:15)
    at /Users/chris/.vscode/extensions/rokucommunity.brightscript-2.17.9/node_modules/brighterscript/dist/Program.js:635:42
    at Array.filter (<anonymous>)
    at Program.getCodeActions (/Users/chris/.vscode/extensions/rokucommunity.brightscript-2.17.9/node_modules/brighterscript/dist/Program.js:635:18)
    at /Users/chris/.vscode/extensions/rokucommunity.brightscript-2.17.9/node_modules/brighterscript/dist/LanguageServer.js:453:61
    at Array.flatMap (<anonymous>)
    at LanguageServer.onCodeAction (/Users/chris/.vscode/extensions/rokucommunity.brightscript-2.17.9/node_modules/brighterscript/dist/LanguageServer.js:453:14)
  Code: -32603 

This error showed up while typing the following:
image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the error while typing the conditional compile block shown in the report, then trace the stack from Util.rangesIntersect through Program.getCodeActions and LanguageServer.onCodeAction. Use the reported TypeScript build paths as entry points and verify that code-action requests no longer fail with an undefined range.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers, devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.