rokucommunity / rokucommunity/brighterscript
signature help doesn't consider parent scopes
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 208
- Forks
- 68
- Avg merge
- 8h 39m
- Merged PRs (30d)
- 39
Description
Program.getSignatureHelp doesn't properly recognize signatures found in parent scopes. This was uncovered during the efforts of #252 when we realized that XmlScope.getFiles only returned the files directly referenced by that scope (and not parent scopes).
We need to refactor the getSignatureHelp function to consider the entire scope inheritance chain when scanning for function signatures, and a similar concept when scanning for class method signatures.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Program.getSignatureHelp and inspect how it scans scopes for function signatures, using the XmlScope.getFiles behavior and issue #252 as context. Trace the parent-scope chain and apply the same consideration to class method signatures. Done means signatures from inherited parent scopes are recognized in both cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100